Skip to content

Code polishing for unifying code of different bars and spinner #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Code polishing for unifying code of different bars and spinner #149

wants to merge 12 commits into from

Conversation

@rlalik
Copy link
Contributor

@rlalik rlalik commented May 7, 2025

The code of four progress classes was polished:

  • headers were sorted,
  • Settings tuple was sorted that common options occupy more-less same positions in the tuple - it allows to easier find common pattern with diff between files,
  • signatures for same like functions were unified,
  • some redundant pieces of code were removed,
  • whole code was formatted with clang-format-20 with column width set at 100.

@rlalik
Copy link
Contributor Author

rlalik commented May 7, 2025

What I can do is I can squash commits to a single one.
I can also reformat with clang-format other files of the project which I didn't touch yet (to make changes as small as possible). One uses Windows end-line markers which could be fixed as well).

@p-ranav
Copy link
Owner

p-ranav commented May 9, 2025

I would happily accept your suggested changes. Thanks!

@rlalik
Convert all dos files (line ending) to unix files
6a712f8
@rlalik
clang-format all files, regenerate single_header
8444674
@rlalik
Update clang-format.bash script
7f2e86a 
Since the .clang-format file is present, the clang-format is called with
--style=file
Also single_header is excluded from clang-format as it is generated by
the separate script.
@rlalik
Copy link
Contributor Author

rlalik commented Sep 21, 2025

I would happily accept your suggested changes. Thanks!

Well, I am happy that you like this. What I did now is, I polished all the remaining files - mainly run clang-format on them. I also fixed the clang-format.bash script. I also regenerated the single_header file.

I would recommend to add calling clang-format.bash and then to create single_header file into workflow.

It seems that there were dos files. If you do development on windows, worth to fix file endings. I can include a simple script using dos2unix program to fix the files if you like. It then could be then also part of the workflow after some editing on windows (of course will not work on windows).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rlalik @p-ranav